Basic Language Menu #936
Basic Language Menu #936
Conversation
github-actions
bot
added
Changes: C#
|
should do |
Actually it should probably be a subcategory of Speech. Along with Accents as another subcategory. |
|
Please do not change the default GC Languages, this is the more easy for anyone to understand what its is, anything "lore" or dunno related should be choosen by servers not in base EE. So BY GOD, dod not replace GC, even the Tau-Cetic yml file should NOT have a color if default. |
FoxxoTrystan
added
Size: 4-Small
|
Tho characterItemGroup is cool, that i can agree. |
No. GC is getting replaced specifically because it's a Joke language, and the new one replacing it has actual syllable structures that make it "sound" like real words someone would actually stay instead of "WOOBY GUBB BAZOOP". When I get syllable structures for the remaining languages, they're getting un-joked as well. Having GC in this codebase is kinda unacceptable. |
|
Having Second-Person text in these is also unacceptable. I went ahead and removed the default color from TCB, and also fixed Sign Language awfullness by removing the genuinely terrible replacements. |
There was a problem hiding this comment.
Fine if you wana remove GC, please do it correctly.
Regardning Languages.yml folder, please avoid making multiple variations, just regroup it in one languages.yml file or seperate them like you did but also those in languages.yml
example animals.yml can be their own thing.
Right now slightly, its a tiny mess.
Also is it possible to to edit MaxItems on characterItemGroup with a trait?
Okay! Now that I'm not distracted, I've gone ahead and made improvements to the organization of the Languages folder. |
FoxxoTrystan
requested review from
a team,
Peptide90,
Pspritechologist and
OldDanceJacket
and removed request for
a team
|
Okay, last thing to do. I've gone ahead and setup subcategories for the Speech tab, so that it now includes tabs for Accents and Languages. Which now include more appropriate language related traits. There's also now a characterItemGroup for Accents, so that people can't grief by taking 5+ accents.
|
Description
This is a very early take on a Language menu, making use of the new CharacterItemGroups functionality, as well as functionality added to the trait system that allows it to add and remove languages directly. This PR adds in the languages Tau-Cetic Basic(taking the place of Galactic Common), Tradeband, Freespeak, Elyran Standard, and Sol Common(I'm replacing the extremely basic bastardized Sol Common we had before with the fully realized version of it from Bay12).
Media
Changelog
🆑